Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Preload assessment stakeholder relationships #544

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Oct 26, 2023

The assessment stakeholder relationships need to be preloaded so that the applications/id/assessments and archetypes/id/assessments subresources populate their association fields properly.

@mansam mansam requested a review from jortel October 26, 2023 16:27
@mansam mansam changed the title Preload assessment stakeholder relationships 🐛 Preload assessment stakeholder relationships Oct 26, 2023
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mansam mansam force-pushed the preload-assessment-stakeholders branch from 9efa6ff to f827747 Compare October 27, 2023 15:42
@mansam mansam merged commit 4d5196c into konveyor:main Oct 27, 2023
11 checks passed
mansam added a commit that referenced this pull request Oct 27, 2023
This was missed in the original PR. #544

Signed-off-by: Sam Lucidi <[email protected]>
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
The assessment stakeholder relationships need to be preloaded so that
the `applications/id/assessments` and `archetypes/id/assessments`
subresources populate their association fields properly.

Signed-off-by: Sam Lucidi <[email protected]>
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants