Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 DepReport aggregated by name. #558

Merged
merged 3 commits into from
Nov 15, 2023
Merged

🐛 DepReport aggregated by name. #558

merged 3 commits into from
Nov 15, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Nov 14, 2023

Update /analyses/report/dependencies to group by (provider, name) instead of (name, version, sha). Currently, provider is always "".

Removes DepReport fields:

  • version
  • sha

Also fixes DepAppReport.SHA JSON field name.

fixes: #557

@jortel jortel force-pushed the dep-fixes branch 2 times, most recently from 0b30d73 to 3496d6c Compare November 14, 2023 22:12
Signed-off-by: Jeff Ortel <[email protected]>
@sjd78
Copy link
Member

sjd78 commented Nov 15, 2023

Successfully tested with UI on konveyor/tackle2-ui#1536.

@jortel jortel marked this pull request as ready for review November 15, 2023 20:00
Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel merged commit ce5a30e into konveyor:main Nov 15, 2023
11 of 12 checks passed
sjd78 added a commit to konveyor/tackle2-ui that referenced this pull request Nov 15, 2023
…etails (#1536)

Resolves: #1338
Resolves: https://issues.redhat.com/browse/MTA-1585

Depends on hub change konveyor/tackle2-hub#557
/ konveyor/tackle2-hub#558.

Summary of changes:
  - The dependency table will show a single row for every named
    dependency.
  - Multiple versions will be aggregated as a single row.
  - Details about multiple versions will be available in the details
    drawer.
  - The details view application table will show the application +
    version, allowing for all versions used to be listed.

---------

Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update report dependencies endpoint to group by name only
3 participants