-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 DepReport aggregated by name. #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortel
force-pushed
the
dep-fixes
branch
2 times, most recently
from
November 14, 2023 22:12
0b30d73
to
3496d6c
Compare
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Successfully tested with UI on konveyor/tackle2-ui#1536. |
mansam
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jeff Ortel <[email protected]>
sjd78
added a commit
to konveyor/tackle2-ui
that referenced
this pull request
Nov 15, 2023
…etails (#1536) Resolves: #1338 Resolves: https://issues.redhat.com/browse/MTA-1585 Depends on hub change konveyor/tackle2-hub#557 / konveyor/tackle2-hub#558. Summary of changes: - The dependency table will show a single row for every named dependency. - Multiple versions will be aggregated as a single row. - Details about multiple versions will be available in the details drawer. - The details view application table will show the application + version, allowing for all versions used to be listed. --------- Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update /analyses/report/dependencies to group by (provider, name) instead of (name, version, sha). Currently, provider is always "".
Removes DepReport fields:
Also fixes DepAppReport.SHA JSON field name.
fixes: #557