Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 TechDependencies deduplicated with direct taking priority. #573

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Dec 5, 2023

TechDependencies deduplicated with direct taking priority.
The solution is to sort the dependencies with DIRECT first. Then relax the Create() to ignore dups on conflict.
The dependencies are not a memory concern.

fixes: #572

@jortel jortel requested a review from mansam December 5, 2023 20:00
Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tolerate duplicate analysis dependencies.
2 participants