🐛 Questionnaire validation should tolerate order fields having value 0
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Lucidi <[email protected]>
mansam
force-pushed
the
fix-questionnaire-order-0-validation
branch
from
43c1dbd
to
bd16526
Compare
djzager
added
the
do-not-merge/hold
jortel
reviewed
Dec 6, 2023
| @@ -47,3 +47,7 @@ var ( | |||
| } | |||
| Samples = []api.Questionnaire{Questionnaire1} | |||
| ) | |||
|
|
|||
| func uint2ptr(u uint) *uint { | |||
There was a problem hiding this comment.
Perhaps we should use https://pkg.go.dev/github.com/gotidy/ptr instead of writing our own?
|
Test failures are known to be unrelated to this PR. Merging. |
djzager
removed
the
do-not-merge/hold
This was referenced Dec 11, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requiredbinding validation can't differentiate an int with value 0 from a value that isn't present. Updateorderfields on questionnaire structs to be represented as a pointer that must not be nil. Also disableexcluded_withvalidations that don't work on 0 length slices.