Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Task report files #577

Merged
merged 19 commits into from
Dec 19, 2023
Merged

✨ Task report files #577

merged 19 commits into from
Dec 19, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Dec 13, 2023 •
edited
Loading

Add support for:

  • TaskReport attached files. The addon (and tackle2-addon command) can attach files with command output and/or log files.
  • File API to support creating empty files.
  • File API to support append content - PATCH /files/:id.
  • Addon (adapter) to support attach files to the task report.

Reaper updated to support fields with array of refs. New tag ref=[]file

Example:

 - '[CMD] Running: /usr/bin/konveyor-analyzer --provider-settings /addon/opt/settings.json --output-file /addon/report.yaml --no-dependency-rules --rules /addon/rules/rulesets/1/rules --rules /addon/rules/rulesets/24/rules --rules /addon/rules/rulesets/20/rules --label-selector konveyor.io/target=cloud-readiness --dep-label-selector !konveyor.io/dep-source=open-source'
    - '[CMD] /usr/bin/konveyor-analyzer succeeded.'
    - '[CMD] Running: /usr/bin/konveyor-analyzer-dep --provider-settings /addon/opt/settings.json --output-file /addon/deps.yaml'
    - '[CMD] /usr/bin/konveyor-analyzer-dep succeeded.'
    - 'Analysis reported. duration: 102.5784ms'
    - '[TAG] Tagging Application 4.'
    - Facts updated.
    - Done.
attached:
    - id: 989
      name: konveyor-analyzer.output
      activity: 44
    - id: 991
      name: konveyor-analyzer-dep.output
      activity: 50

jortel
jortel commented Dec 13, 2023
View reviewed changes
migration/v12/model/core.go Outdated Show resolved Hide resolved
@jortel jortel mentioned this pull request Dec 13, 2023
Merged
@jortel jortel marked this pull request as ready for review December 15, 2023 16:30
@jortel jortel requested a review from mansam December 18, 2023 16:46
@jortel jortel mentioned this pull request Dec 18, 2023
Merged
mansam
mansam requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments

api/task.go Outdated Show resolved Hide resolved
binding/client.go Outdated
Reader: bytes.NewReader([]byte{}),
},
}
err = r.FileSend(path, http.MethodPut, fields, object)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be http.MethodPost

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

migration/v12/migrate.go Outdated
"gorm.io/gorm"
)

var log = logr.WithName("migration|v11")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the log name should be migration|v12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
We may want to correct this in the tooling.

@jortel
checkpoint
3ea94ed 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
200b063 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
f39ace7 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
0fac993 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
9bff0d3 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
2a84b48 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
95abce6 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
fc6b15d 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
be658ac 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
8a20694 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
Add inject query param.
4d1a6d2 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
Renamed attachment.
77f9b8f 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
renamed inject to merged.
b621ec0 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
f36df28 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
658814c 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
checkpoint
a62eb23 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
Fixed review comments.
53d3d3a 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
File patch must only update updateUser.
c103965 
Signed-off-by: Jeff Ortel <[email protected]>
@jortel
Fixed test.
f5acf5e 
Signed-off-by: Jeff Ortel <[email protected]>
mansam
mansam approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel jortel merged commit f09d0b2 into konveyor:main Dec 19, 2023
11 checks passed
jortel added a commit to konveyor/tackle2-addon that referenced this pull request Dec 19, 2023
@jortel
✨ Command verbosity with task report files. (#50)
1119ca4 
Add command reporting verbosity. This is intended to better support
troubleshooting.
Mainly, the support for level=_LiveOutput_. This _streams_ command
output to files attached to the task report.

The output reporting is rate-limited using a _backoff_ algorithm. 

Add command `New` _constructor_ and update the repository package to use
it.

**Requires**: konveyor/tackle2-hub#577

Example:
```
 - '[CMD] Running: /usr/bin/konveyor-analyzer --provider-settings /addon/opt/settings.json --output-file /addon/report.yaml --no-dependency-rules --rules /addon/rules/rulesets/1/rules --rules /addon/rules/rulesets/24/rules --rules /addon/rules/rulesets/20/rules --label-selector konveyor.io/target=cloud-readiness --dep-label-selector !konveyor.io/dep-source=open-source'
    - '[CMD] /usr/bin/konveyor-analyzer succeeded.'
    - '[CMD] Running: /usr/bin/konveyor-analyzer-dep --provider-settings /addon/opt/settings.json --output-file /addon/deps.yaml'
    - '[CMD] /usr/bin/konveyor-analyzer-dep succeeded.'
    - 'Analysis reported. duration: 102.5784ms'
    - '[TAG] Tagging Application 4.'
    - Facts updated.
    - Done.
attached:
    - id: 989
      name: konveyor-analyzer.output
      activity: 44
    - id: 991
      name: konveyor-analyzer-dep.output
      activity: 50
```

---------

Signed-off-by: Jeff Ortel <[email protected]>
jortel added a commit to konveyor/tackle2-addon-analyzer that referenced this pull request Dec 19, 2023
@jortel
✨ Add support for verbosity. (#68)
386d508 
Add support for verbosity. This mainly applies to reporting in task
activity.

When requested, the command output is included (live) in the activity
log. This provides more detail and better insight into what the command
is doing _currently_.

Requires:
- konveyor/tackle2-hub#577
- konveyor/tackle2-addon#50

---------

Signed-off-by: Jeff Ortel <[email protected]>
This was referenced Dec 21, 2023
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansam mansam mansam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jortel @mansam