🐛 Detect image issues. #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
jortel
force-pushed
the
image-pull-backoff
branch
from
89feb66
to
23bb909
Compare
mansam
reviewed
Jun 27, 2024
task/manager.go
Outdated
| if state.Waiting != nil { | ||
| waiting := state.Waiting | ||
| reason := strings.ToLower(waiting.Reason) | ||
| if strings.Contains(reason, "invalid") || strings.Contains(reason, "backoff") { |
There was a problem hiding this comment.
Would it be better to specifically match ImagePullBackOff and InvalidImageName, if those are the only cases we intend to catch?
There was a problem hiding this comment.
Perhaps but I cannot find a const in v1 or core packages and concerned about making the match too narrow should the strings change a little. Also, a little broader match may catch other similar issues.
I cannot find an Enum for all the possible values.
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
shawn-hurley
added a commit
that referenced
this pull request
Jul 3, 2024
This reverts commit 83b8519.
dymurray
pushed a commit
that referenced
this pull request
Jul 3, 2024
shawn-hurley
pushed a commit
that referenced
this pull request
Jul 5, 2024
Re-apply reverted #678 re-based on current main. --------- Signed-off-by: Jeff Ortel <[email protected]>
This was referenced Jul 10, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect malformed fqin and image pull backoff. When detected, the task is failed and reported with error and event.
Reported as:
Detects:
closes: #677