🐛 Migration wave name is min 3/max 20 chars only when provided (#1156)

Resolves https://issues.redhat.com/browse/MTA-906 --------- Co-authored-by: Ian Bolton <[email protected]>
konveyor · Jul 19, 2023 · 34e68b7 · 34e68b7
1 parent 0b20ab3
commit 34e68b7
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/client/src/app/pages/migration-waves/components/migration-wave-form.tsx b/client/src/app/pages/migration-waves/components/migration-wave-form.tsx
@@ -138,9 +138,21 @@ export const WaveForm: React.FC<WaveFormProps> = ({
   const validationSchema: yup.SchemaOf<WaveFormValues> = yup.object().shape({
     name: yup
       .string()
-      .trim()
-      .min(3, t("validation.minLength", { length: 3 }))
-      .max(120, t("validation.maxLength", { length: 120 })),
+      .defined()
+      .test(
+        "min-char-check",
+        "Name is invalid. The name must be between 3 and 120 characters ",
+        (value) => {
+          if (!!value) {
+            const schema = yup
+              .string()
+              .min(3, t("validation.minLength", { length: 3 }))
+              .max(120, t("validation.maxLength", { length: 120 }));
+            return schema.isValidSync(value);
+          }
+          return true;
+        }
+      ),
     startDateStr: yup
       .string()
       .required(t("validation.required"))