Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Pass all associated rule labels to analyzer #1085

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

ibolton336
Copy link
Member

  • Passes a list of all labels that are associated with rule files along to the analyzer.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.22 ⚠️

Comparison is base (452cd57) 46.91% compared to head (89883ff) 46.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
- Coverage   46.91%   46.70%   -0.22%     
==========================================
  Files         177      177              
  Lines        4442     4462      +20     
  Branches     1027     1034       +7     
==========================================
  Hits         2084     2084              
- Misses       2285     2304      +19     
- Partials       73       74       +1     
Flag Coverage Δ
unitests 46.70% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/src/app/common/CustomRules/rules-utils.tsx 8.69% <0.00%> (-0.40%) ⬇️
...s/applications/analysis-wizard/analysis-wizard.tsx 68.00% <ø> (ø)
...ages/applications/analysis-wizard/custom-rules.tsx 13.51% <0.00%> (-0.68%) ⬇️
...c/app/pages/applications/analysis-wizard/schema.ts 92.30% <ø> (ø)
...pages/applications/analysis-wizard/set-targets.tsx 9.63% <0.00%> (-1.33%) ⬇️
client/src/app/queries/rulesets.ts 15.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Test wise, it doesn't break anything but I don't have a rule set file to fully exploit those labels.

@ibolton336
Copy link
Member Author

LGTM. Test wise, it doesn't break anything but I don't have a rule set file to fully exploit those labels.

Thanks Gilles - I have been using the rule files here: https://github.com/pranavgaikwad/rulesets/tree/main/default/generated/eap7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants