-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use latest prerelease version for PF V5 #1155
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
=======================================
Coverage 44.09% 44.09%
=======================================
Files 177 177
Lines 4499 4499
Branches 1007 1007
=======================================
Hits 1984 1984
Misses 2504 2504
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
client/package.json
Outdated
"@patternfly/patternfly": "prerelease", | ||
"@patternfly/react-charts": "prerelease", | ||
"@patternfly/react-code-editor": "prerelease", | ||
"@patternfly/react-core": "prerelease", | ||
"@patternfly/react-table": "prerelease", | ||
"@patternfly/react-tokens": "prerelease", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PF guys meant "^5.0.0-prerelease" to get the latest prerelease versions.
From the semver docs:
^1.2.3-beta.2 := >=1.2.3-beta.2 <2.0.0-0 Note that prereleases in the 1.2.3 version will be allowed, if they are greater than or equal to beta.2. So, 1.2.3-beta.4 would be allowed, but 1.2.4-beta.2 would not, because it is a prerelease of a different [major, minor, patch] tuple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Gilles Dubreuil <[email protected]>
Signed-off-by: Gilles Dubreuil <[email protected]>
The prerelease version stanza pull the latest prerelease versions of PF allowing us to not have to update those dependencies every couple of days as this is moving quite fast.