✨ Applications: Update Notification and refactors update/create modal

[gildub]

While resolving the related notification issues (see associated MTA-1024) this refactors create/update modal.

Includes following changes :

• Push edit/create notifications down to ApplicationForm
• Use onClose to replace onSave and onCancel
• Consolidate New/Edit Modal duplication

Partially address https://issues.redhat.com/browse/MTA-1024

[codecov]

Codecov Report

Patch coverage: 40.00% and no project coverage change.

Comparison is base (97005b7) 44.10% compared to head (b4c2e1c) 44.10%.
Report is 1 commits behind head on main.

❗ Current head b4c2e1c differs from pull request most recent head e81316f. Consider uploading reports for the commit e81316f to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   44.10%   44.10%           
=======================================
  Files         177      177           
  Lines        4501     4507    +6     
  Branches     1007     1007           
=======================================
+ Hits         1985     1988    +3     
- Misses       2505     2508    +3     
  Partials       11       11           

Flag	Coverage Δ
unitests	44.10% <40.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
client/src/app/queries/applications.ts	49.01% <0.00%> (ø)
...s/components/application-form/application-form.tsx	55.81% <50.00%> (-0.17%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ibolton336]

I think we could use our custom useUpdateApplicationMutation & useCreateApplicationMutation hooks to 1) narrow this type to something like "appName: string" & 2) Pass the name from the mutation function variable object param to the success handler.

e.g.

export const useUpdateApplicationMutation = (
  onSuccess: (appName: string) => void,
  onError: (err: AxiosError) => void
) => {
  const queryClient = useQueryClient();
  return useMutation({
    mutationFn: ({ application }: { application: Application }) =>
      updateApplication(application),

    onSuccess: (_, vars) => {
      onSuccess(vars.application.name);
      queryClient.invalidateQueries([ApplicationsQueryKey]);
    },
    onError: onError,
  });
};

& then in the success handler:

  const onCreateUpdateApplicationSuccess = (appName: string) => {
    if (application) {
      pushNotification({
        title: t("toastr.success.createWhat", {
          type: t("terms.application"),
          what: appName,
        }),
        variant: "success",
      });
    } else {
  title: t("toastr.success.saveWhat", {
          type: t("terms.application"),
          what: appName,
        }),
        variant: "success",
    }
    onClose();
  };

[gildub]

@ibolton336, generalizing this approach is, I believe out of scope of this PR, please let's discuss how we are going to do that here : #1214.

[ibolton336]

Np - we can address the missing entity name in the update notification later. However, I think it would make more sense to have two separate handlers for create / update here.

[gildub]

@ibolton336, I agree it makes sense to have separate handlers. Let me change that.

[ibolton336]

See inline.