Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix application update #1259

Merged
merged 2 commits into from
Aug 8, 2023
Merged

🐛 Fix application update #1259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f66cc
:bug: Fix application update
ibolton336 Aug 7, 2023
bec7329
Merge branch 'main' into fix-app-update
ibolton336 Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/src/app/pages/applications/components/application-form/application-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,13 +356,13 @@
formValues.version,
formValues.packaging
),
review: undefined, // The review should not updated through this form
id: formValues.id,
migrationWave: application ? application.migrationWave : null,
identities: application?.identities ? application.identities : undefined,
};

if (application) {
updateApplication(payload);
updateApplication({ ...payload });

Check warning on line 365 in client/src/app/pages/applications/components/application-form/application-form.tsx

View check run for this annotation

Codecov / codecov/patch

client/src/app/pages/applications/components/application-form/application-form.tsx#L365 

Added line #L365 was not covered by tests
} else {
createApplication(payload);
}
Expand Down
Loading