✨ Introducing ActionsColumn Component in Assessment Table #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ibolton336
commented
Aug 25, 2023
•
ibolton336
commented
- This PR introduces the ActionsColumn component in the assessment table
ibolton336
force-pushed
the
use-new-actions-column
branch
from
8782c88
to
41545ea
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
Coverage 43.04% 43.04%
=======================================
Files 145 145
Lines 4330 4330
Branches 999 999
=======================================
Hits 1864 1864
Misses 2454 2454
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ibolton336
force-pushed
the
use-new-actions-column
branch
2 times, most recently
from
36a056b
to
cfb3c9f
Compare
mturley
approved these changes
Aug 28, 2023
| onClick={() => | ||
| setSaveApplicationModalState(application) | ||
| } | ||
| ></Button> |
There was a problem hiding this comment.
You can make this empty Button tag self-closing
| setApplicationDependenciesToManage(application), | ||
| }, | ||
| ]} | ||
| ></ActionsColumn> |
There was a problem hiding this comment.
Same here with ActionsColumn
ibolton336
force-pushed
the
use-new-actions-column
branch
from
4b48443
to
d9d513c
Compare
Signed-off-by: ibolton336 <[email protected]>
ibolton336
force-pushed
the
use-new-actions-column
branch
from
d9d513c
to
725febc
Compare
+1 Opened this issue to track #1318 |
mturley
added a commit
that referenced
this pull request
Sep 5, 2023
Part of #1264. Uses the ActionsColumn component pattern introduced in #1314 to add a kebab menu for actions shown in [this mockup](https://www.sketch.com/s/af50e991-8061-4b69-84c1-c11241e274f2/a/eldjjKW). All 3 actions are currently stubs to unblock @sjd78 from integrating his Edit functionality. PR to implement Duplicate and Delete will be next. Follows the pattern found in this PF example for "danger" menu items (red text below a separator): https://www.patternfly.org/components/menus/menu#danger-menu-item --------- Signed-off-by: Mike Turley <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.