🐛 Fix getIconByRisk in answer-table.tsx
#1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
=======================================
Coverage 43.04% 43.04%
=======================================
Files 145 145
Lines 4330 4330
Branches 999 999
=======================================
Hits 1864 1864
Misses 2454 2454
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
While working on upgrading eslint, a switch/case `no-fallthrough` error was found in the `getIconByRisk` function in the `AnswerTable` component. This error would cause a risk of "red" to actually render as a risk of "yellow". Fixing it separately from the eslint upgrade seems like a good thing. Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
answer-table-getIconByRisk
branch
from
2e78cf4
to
d5efffc
Compare
ibolton336
pushed a commit
to ibolton336/tackle2-ui
that referenced
this pull request
Aug 29, 2023
While working on upgrading eslint (PR konveyor#1291), a switch/case `no-fallthrough` error was found in the `getIconByRisk` function in the `AnswerTable` component. This error would cause a risk of "red" to actually render as a risk of "yellow". Fixing it separately from the eslint upgrade seems like a good thing. Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on upgrading eslint (PR #1291), a switch/case
no-fallthrougherror was found in thegetIconByRiskfunction in theAnswerTablecomponent. This error would cause a risk of "red" to actually render as a risk of "yellow". Fixing it separately from the eslint upgrade seems like a good thing.