Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use onChange() instead of setValue() #1319

Merged
merged 2 commits into from
Aug 29, 2023
Merged

🐛 Use onChange() instead of setValue() #1319

merged 2 commits into from
Aug 29, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Aug 29, 2023

Resolves #1317

@gildub gildub self-assigned this Aug 29, 2023
Signed-off-by: Gilles Dubreuil <[email protected]>
@gildub gildub requested a review from ibolton336 August 29, 2023 15:08
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c4d31e) 43.04% compared to head (b206bc5) 43.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   43.04%   43.04%           
=======================================
  Files         145      145           
  Lines        4330     4330           
  Branches      999      999           
=======================================
  Hits         1864     1864           
  Misses       2454     2454           
  Partials       12       12           
Flag Coverage Δ
client 43.04% <100.00%> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pp/pages/applications/analysis-wizard/set-mode.tsx 86.20% <100.00%> (ø)
...ntities/components/identity-form/identity-form.tsx 55.87% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation broken when manually setting values
3 participants