Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Respond to hub API changes for yaml download #1329

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

ibolton336
Copy link
Member

Updates UI interpretation of hub api routes for downloading reports.

For the /applications/:id/analysis endpoint, the API should accept requests with the content type application/x-yaml by setting the accept header to that value in the request.

For the /applications/:id/analysis/report endpoint, there is no specific accept header requirement. We can make requests to this endpoint without needing to specify a particular accept header.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9287edd) 42.58% compared to head (48c4b67) 42.58%.

❗ Current head 48c4b67 differs from pull request most recent head e1cde8f. Consider uploading reports for the commit e1cde8f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1329   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files         136      136           
  Lines        4220     4220           
  Branches     1000     1000           
=======================================
  Hits         1797     1797           
  Misses       2411     2411           
  Partials       12       12           
Flag Coverage Δ
client 42.58% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants