Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Review archetypes #1376

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 changed the title Review archetypes code implementation ✨ Review archetypes code implementation Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.08% 🎉

Comparison is base (6825317) 41.46% compared to head (038230e) 41.54%.

❗ Current head 038230e differs from pull request most recent head 0dd192e. Consider uploading reports for the commit 0dd192e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
+ Coverage   41.46%   41.54%   +0.08%     
==========================================
  Files         137      137              
  Lines        4293     4282      -11     
  Branches     1038     1035       -3     
==========================================
- Hits         1780     1779       -1     
+ Misses       2424     2415       -9     
+ Partials       89       88       -1     
Flag Coverage Δ
client 41.54% <40.00%> (+0.08%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/src/app/api/models.ts 100.00% <ø> (ø)
client/src/app/queries/reviews.ts 23.80% <25.00%> (+3.05%) ⬆️
client/src/app/Paths.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 changed the title ✨ Review archetypes code implementation ✨ Review archetypes Sep 20, 2023
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments. No real blockers.

Also, humm...interesting that the review data for an archetype isn't shown anywhere else other than the review view of that archetype. I don't see it anywhere in the enhancement doc, but I'd think it'll probably need a set of views added similar to how the applications show reviews...

client/src/app/queries/reviews.ts Outdated Show resolved Hide resolved
client/src/app/pages/archetypes/archetypes-page.tsx Outdated Show resolved Hide resolved
@ibolton336 ibolton336 force-pushed the review-archetypes branch 2 times, most recently from 93753ae to 2d191a6 Compare September 20, 2023 20:13
@ibolton336
Copy link
Member Author

WIP - pending hub change

@ibolton336 ibolton336 marked this pull request as draft September 20, 2023 20:49
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Archetypes flow
2 participants