-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Review archetypes #1376
✨ Review archetypes #1376
Conversation
ae28b9a
to
d5569a2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
+ Coverage 41.46% 41.54% +0.08%
==========================================
Files 137 137
Lines 4293 4282 -11
Branches 1038 1035 -3
==========================================
- Hits 1780 1779 -1
+ Misses 2424 2415 -9
+ Partials 89 88 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments. No real blockers.
Also, humm...interesting that the review data for an archetype isn't shown anywhere else other than the review view of that archetype. I don't see it anywhere in the enhancement doc, but I'd think it'll probably need a set of views added similar to how the applications show reviews...
client/src/app/pages/review/components/review-form/review-form.tsx
Outdated
Show resolved
Hide resolved
93753ae
to
2d191a6
Compare
WIP - pending hub change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
9d6a48b
to
0dd192e
Compare
Closes Review Archetypes flow #1279