Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fully unique ids for answer selections #1387

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

ibolton336
Copy link
Member

  • Avoids bugs when similar questions are entered in the form with the same text causing the wrong answer to be selected. Adds unique IDs for selectable answers and questions.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.20% ⚠️

Comparison is base (59cbfc5) 41.53% compared to head (67442c0) 41.34%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   41.53%   41.34%   -0.20%     
==========================================
  Files         137      138       +1     
  Lines        4290     4334      +44     
  Branches     1036     1039       +3     
==========================================
+ Hits         1782     1792      +10     
- Misses       2420     2454      +34     
  Partials       88       88              
Flag Coverage Δ
client 41.34% <20.00%> (-0.20%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/src/app/queries/assessments.ts 25.00% <11.11%> (-1.09%) ⬇️
client/src/app/pages/assessment/form-utils.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants