🐛 Fix useFetchAssessments query key
#1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query key for `useFetchAssessments` was set to use the same query key as `useFetchQuestionnaires`. Setting the query keys to appropriate values prevent a situation where the first use of one of them will cause them both to have the same response. Having an `Assessment[]` returned instead of a `Questionnaire[]`, or vice versa, does cause some problems. Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
=======================================
Coverage 41.34% 41.34%
=======================================
Files 138 138
Lines 4334 4334
Branches 1039 1039
=======================================
Hits 1792 1792
Misses 2454 2454
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ibolton336
approved these changes
Sep 21, 2023
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query key for
useFetchAssessmentswas set to use the same query key asuseFetchQuestionnaires. Setting the query keys to appropriate values prevent a situation where the first use of one of them will cause them both to have the same response. Having anAssessment[]returned instead of aQuestionnaire[], or vice versa, does cause some problems.