Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Save as Draft not working #1401

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Sep 25, 2023

Closes https://issues.redhat.com/browse/MTA-1207

  • AssessmentWizard component was not re-rendering between assessment fetches
  • Adds a function to check if partial questions have been answered to help determine save as draft status

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f628007) 41.22% compared to head (0a07e59) 41.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1401   +/-   ##
=======================================
  Coverage   41.22%   41.23%           
=======================================
  Files         138      138           
  Lines        4349     4351    +2     
  Branches     1043     1045    +2     
=======================================
+ Hits         1793     1794    +1     
- Misses       2468     2469    +1     
  Partials       88       88           
Flag Coverage Δ
client 41.23% <33.33%> (+<0.01%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ents/custom-wizard-footer/custom-wizard-footer.tsx 92.00% <100.00%> (+0.33%) ⬆️
client/src/app/queries/assessments.ts 24.52% <0.00%> (-0.48%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants