Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add detail for archetype reviews in drawer #1475

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

ibolton336
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a78bc28) 40.84% compared to head (c0ce360) 40.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage   40.84%   40.84%           
=======================================
  Files         139      139           
  Lines        4456     4456           
  Branches     1018     1018           
=======================================
  Hits         1820     1820           
  Misses       2624     2624           
  Partials       12       12           
Flag Coverage Δ
client 40.84% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 merged commit acdb3f3 into konveyor:main Oct 12, 2023
6 checks passed
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change just shows another list of archetypes and if they were reviewed, but doesn't show the elements of the review per archetype. Does that line up with what the jira ticket is asking for?

Comment on lines +124 to +130
<Title headingLevel="h3" size="md">
{t("terms.migrationWave")}
</Title>
<Text component="small">
{application?.migrationWave
? application.migrationWave.name
: t("terms.unassigned")}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of the fix for MTA-1382? I don't see anything in the jira about migration waves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants