Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ConfirmDeleteDialog: always clear name input value on action #1479

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Oct 16, 2023

ConfirmDeleteDialog requires the user to enter the item's name before the delete button is enabled. The user entered text was being cleared on Cancel and Close, but not on Confirm. Action handlers now clear the user entered text on ALL actions.

Resolves: #1478

ConfirmDeleteDialog requires the user to enter the item's name
before the delete button is enabled.  The user entered text was
being cleared on Cancel and Close, but not on Confirm.  Action
handlers now clear the user entered text on ALL actions.

Resolves: konveyor#1478

Signed-off-by: Scott J Dickerson <[email protected]>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9096dcd) 40.82% compared to head (09de2f8) 40.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1479   +/-   ##
=======================================
  Coverage   40.82%   40.82%           
=======================================
  Files         139      139           
  Lines        4458     4458           
  Branches     1018     1018           
=======================================
  Hits         1820     1820           
  Misses       2626     2626           
  Partials       12       12           
Flag Coverage Δ
client 40.82% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questionnaire delete: On a second delete, the name of the previously deleted item is still showing
2 participants