Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Accurately represent upload state in binary upload step #1487

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

ibolton336
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ded98a9) 40.31% compared to head (225bb3e) 40.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1487      +/-   ##
==========================================
- Coverage   40.31%   40.28%   -0.04%     
==========================================
  Files         143      143              
  Lines        4524     4530       +6     
  Branches     1108     1112       +4     
==========================================
+ Hits         1824     1825       +1     
- Misses       2603     2608       +5     
  Partials       97       97              
Flag Coverage Δ
client 40.28% <33.33%> (-0.04%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/applications/analysis-wizard/analysis-wizard.tsx 61.98% <100.00%> (ø)
client/src/app/queries/applications.ts 32.45% <100.00%> (+0.59%) ⬆️
...tions/analysis-wizard/components/upload-binary.tsx 12.24% <0.00%> (-0.13%) ⬇️
client/src/app/queries/tasks.ts 15.38% <20.00%> (-1.76%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibolton336 ibolton336 merged commit ed39248 into konveyor:main Oct 25, 2023
6 checks passed
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants