🐛 inherit review data from multiple archetypes #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
mta-1382
branch
3 times, most recently
from
249e925
to
e8573fb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1493 +/- ##
=======================================
Coverage 40.22% 40.22%
=======================================
Files 143 143
Lines 4539 4539
Branches 1096 1096
=======================================
Hits 1826 1826
Misses 2616 2616
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ibolton336
force-pushed
the
mta-1382
branch
2 times, most recently
from
ac929b1
to
171da19
Compare
sjd78
requested changes
Oct 27, 2023
...t/src/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
Outdated
Show resolved
Hide resolved
| isFetching: isFetchingArchetypes, | ||
| error: archetypesFetchError, | ||
| refetch: fetchArchetypes, | ||
| } = useFetchArchetypes(); |
There was a problem hiding this comment.
Just a thought -- when the application assessment + analysis tables are combine, it would be good to rework the data fetching & data cross-references into its own hook. That way the hook can do something like...
heavyApplication = {
...applicaiton,
archetypes: mapRefsToObject(applicaiton.archetypes, archetypes),
isReviewed: ....,
hasReviewedArchetype: ...,
}...then the component code can just wire things together
client/src/app/pages/applications/components/application-detail-drawer/review-fields.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/applications/components/application-detail-drawer/review-fields.tsx
Outdated
Show resolved
Hide resolved
sjd78
reviewed
Oct 30, 2023
| item: ReviewDrawerLabelItem, | ||
| labelText?: string | number | ||
| ) => { | ||
| console.log("generateReviewLabel", item, labelText); |
There was a problem hiding this comment.
Don't forget to remove the console log.
client/src/app/pages/applications/components/application-detail-drawer/review-fields.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/applications/components/application-detail-drawer/review-fields.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
sjd78
reviewed
Oct 30, 2023
client/src/app/pages/applications/components/application-detail-drawer/review-label.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ibolton336 <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MTA-1382
https://issues.redhat.com/browse/MTA-1537