Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add archetype risk to drawer #1522

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

ibolton336
Copy link
Member

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (84cc866) 40.70% compared to head (36308b8) 40.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1522      +/-   ##
==========================================
- Coverage   40.70%   40.65%   -0.06%     
==========================================
  Files         145      145              
  Lines        4589     4607      +18     
  Branches     1076     1077       +1     
==========================================
+ Hits         1868     1873       +5     
- Misses       2707     2720      +13     
  Partials       14       14              
Flag Coverage Δ
client 40.65% <37.50%> (-0.06%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/api/models.ts 100.00% <ø> (ø)
client/src/app/pages/assessment/form-utils.ts 100.00% <100.00%> (ø)
client/src/app/queries/assessments.ts 20.51% <16.66%> (-0.46%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the field title...

@@ -198,6 +199,14 @@ const ArchetypeDetailDrawer: React.FC<IArchetypeDetailDrawerProps> = ({
</DescriptionListDescription>
</DescriptionListGroup>
</DescriptionList>
<TextContent className={spacing.mtLg}>
<Title headingLevel="h3" size="md">
{t("terms.riskFromApplication")}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "riskFromArchetype"?

Signed-off-by: ibolton336 <[email protected]>
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants