-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add archetype risk to drawer #1522
Conversation
Signed-off-by: ibolton336 <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1522 +/- ##
==========================================
- Coverage 40.70% 40.65% -0.06%
==========================================
Files 145 145
Lines 4589 4607 +18
Branches 1076 1077 +1
==========================================
+ Hits 1868 1873 +5
- Misses 2707 2720 +13
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about the field title...
@@ -198,6 +199,14 @@ const ArchetypeDetailDrawer: React.FC<IArchetypeDetailDrawerProps> = ({ | |||
</DescriptionListDescription> | |||
</DescriptionListGroup> | |||
</DescriptionList> | |||
<TextContent className={spacing.mtLg}> | |||
<Title headingLevel="h3" size="md"> | |||
{t("terms.riskFromApplication")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "riskFromArchetype"?
Signed-off-by: ibolton336 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://issues.redhat.com/browse/MTA-1330 --------- Signed-off-by: ibolton336 <[email protected]>
https://issues.redhat.com/browse/MTA-1330