✨ Add Tag Categories to Tag filters #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the following tables, the Tag filter has been enhanced to group
the Tag select by Tag Category:
- Applications
- Issues / All Issues
- Dependencies
Tables that use Tag filters now send a map of group name (category)
to an array of `FilterSelectOptionProps` (tags). The filter render
component `MultiselectFilterControl` has been updated to allow for
grouped and ungrouped arrays of `FilterSelectOptionProps` objects.
Existing item filtering and filter values are still operating as a
`string` or `string[]`. The net effect means that if a tag of the same
name exists in more than one category, and one of them is selected, then
all of them will be selected.
Additional change details:
- Type `OptionPropsWithKey` renamed `FilterSelectOptionProps` for
more consistent type/component naming
- Added some jsdoc to `FilterToolbar`
Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1535 +/- ##
==========================================
- Coverage 40.65% 40.52% -0.14%
==========================================
Files 145 145
Lines 4607 4622 +15
Branches 1077 1084 +7
==========================================
Hits 1873 1873
- Misses 2720 2735 +15
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
… table Signed-off-by: Scott J Dickerson <[email protected]>
|
Refactored to use a single list and have the items display "Category / Tag". |
Follow the UX of the tag fields on data forms.
- Tags are shown with their category name but without grouping
- Toolbar chips are shown with the category in a tooltip and the
tag name as the visible chip
- Filtering will be considered on a TagCategory + Tag basis. Tags
with the same name in multiple categories are distinct.
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
1 task
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-1534
Summary
On the following tables, the Tag filter has been enhanced to show the Tag with Tag Category:
Tables that use Tag filters now use a set of options in the format "Tag Category Name / Tag Name". The filter render component
MultiselectFilterControlhas been updated to have special handling of selected values where the selection chips display the Tag Name and the Tag Category Name is displayed as a tooltip.Existing item filtering and filter values are still operating as a
stringorstring[], but use a string that can uniquely identify each tag. The net effect means that if a tag of the same name exists in more than one category, they are unique. Selecting one of those Tags will only select the tag in that specific category.Additional change details:
OptionPropsWithKeyrenamedFilterSelectOptionPropsfor more consistent type/component namingFilterToolbarScreenshots
Tag chips displayed for selected tags:
Tag filter select:
