🐛 Handle confirm deletes with multiple spaces #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1572 +/- ##
==========================================
+ Coverage 39.41% 39.55% +0.13%
==========================================
Files 146 146
Lines 4775 4786 +11
Branches 1138 1143 +5
==========================================
+ Hits 1882 1893 +11
Misses 2879 2879
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Screen shot (entering spaces in the confirm field): |
ibolton336
approved these changes
Nov 27, 2023
Resolves: https://issues.redhat.com/browse/MTA-1725 When confirming the deletion of an entity by requiring the user to enter the name of the entity, the string check needs to ignore differences in white space. The entity name may contain multiple spaces between words, but not show the spaces when viewing the name outside of an input box. HTML normally collapses multiple spaces into a single space. Also if the confirming name gets an extra space typed, that can cause a hard to see string mismatch. Trimming and then collapsing multiple spaces into a single space before comparing the string avoids this problem. Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
confirm_delete_spaces
branch
from
a673ada
to
89a84b4
Compare
This was referenced Dec 11, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-1725
When confirming the deletion of an entity by requiring the user to enter the name of the entity, the string check needs to ignore differences in white space.
The entity name may contain multiple spaces between words, but not show the spaces when viewing the name outside of an input box. HTML normally collapses multiple spaces into a single space. Also if the confirming name gets an extra space typed, that can cause a hard to see string mismatch. Trimming and then collapsing multiple spaces into a single space before comparing the string avoids this problem.