Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Refactoring to follow up PR #1573 comments #1578

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Nov 30, 2023

Followup changes to #1573:

  • Simplify the assessment risk query
  • Simplify the header for reports / identified risk card header
  • Fixup layout of the review page assessment summary card

Followup changes to konveyor#1573:
  - Simplify the assessment risk query
  - Simplify the header for reports / identified risk card header
  - Fixup layout of the review page assessment summary card

Signed-off-by: Scott J Dickerson <[email protected]>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (85ac7b4) 39.39% compared to head (9adb603) 39.39%.

Files Patch % Lines
client/src/app/queries/assessments.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1578   +/-   ##
=======================================
  Coverage   39.39%   39.39%           
=======================================
  Files         146      146           
  Lines        4810     4810           
  Branches     1152     1151    -1     
=======================================
  Hits         1895     1895           
  Misses       2901     2901           
  Partials       14       14           
Flag Coverage Δ
client 39.39% <0.00%> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants