Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Trim unwanted questionnaire fields on export #1584

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

ibolton336
Copy link
Member

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d2ea8c1) 39.39% compared to head (ea1ca30) 39.36%.

Files Patch % Lines
client/src/app/queries/questionnaires.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
- Coverage   39.39%   39.36%   -0.04%     
==========================================
  Files         146      146              
  Lines        4810     4817       +7     
  Branches     1151     1151              
==========================================
+ Hits         1895     1896       +1     
- Misses       2901     2907       +6     
  Partials       14       14              
Flag Coverage Δ
client 39.36% <12.50%> (-0.04%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 merged commit 4a90493 into konveyor:main Dec 4, 2023
9 checks passed
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend moving the "strip some fields" code to a helper function and writing some unit tests to make sure we can see what is expected to be removed from where and it can be auto-tested.

We can probably write tests against the custom query hooks with data coming from MSW mocks. That would cover it as well.

In summary -- this is a good change to have a unit test for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants