✨ Add assessed archetypes section in drawer #1610
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
==========================================
+ Coverage 39.13% 39.18% +0.05%
==========================================
Files 146 146
Lines 4850 4856 +6
Branches 1205 1209 +4
==========================================
+ Hits 1898 1903 +5
- Misses 2850 2851 +1
Partials 102 102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The view looks ok if the application does not have an archetype or if the archetype has a completed assessment or review. But if the archetype has assessments in progress, the view is broken
✔️ No archetype (looks good):
✔️ Archetype with assessment and review completed:
❌ Archetype but the assessment is not started of in-progress:
So just need to have the 3rd screen there show "None" or similar
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
...ages/applications/components/application-assessment-status/application-assessment-status.tsx
Outdated
Show resolved
Hide resolved
...ages/applications/components/application-assessment-status/application-assessment-status.tsx
Outdated
Show resolved
Hide resolved
...ages/applications/components/application-assessment-status/application-assessment-status.tsx
Outdated
Show resolved
Hide resolved
Address singular translation issue Signed-off-by: ibolton336 <[email protected]>
| const { t } = useTranslation(); | ||
|
|
||
| const { archetypes, isFetching } = useFetchArchetypes(); | ||
| const isAppReviewed = !!application.review; |
There was a problem hiding this comment.
Is the review one for the application or does it include the archetype review? This column may have the same issue as the assessment column...
There was a problem hiding this comment.
The review only includes the app level review. There is no review bool, this is just the actual review object on the application.
sjd78
changed the title
Resolves:
https://issues.redhat.com/browse/MTA-1834
MTA-1878
Inconsistent hover text message for Assessment and Review columns