Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Revert "🐛 Fix session expiry when refresh tokens are disabled" #1615

Closed
wants to merge 1 commit into from

Conversation

fabianvf
Copy link
Contributor

Reverts #1614

CI was red, checking if the reversion flips it back to green

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (eea7835) 39.13% compared to head (6880cad) 39.24%.

❗ Current head 6880cad differs from pull request most recent head 0d48101. Consider uploading reports for the commit 0d48101 to get more accurate results

Files Patch % Lines
client/src/app/axios-config/apiInit.ts 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
+ Coverage   39.13%   39.24%   +0.10%     
==========================================
  Files         146      146              
  Lines        4850     4834      -16     
  Branches     1205     1201       -4     
==========================================
- Hits         1898     1897       -1     
+ Misses       2850     2836      -14     
+ Partials      102      101       -1     
Flag Coverage Δ
client 39.24% <20.00%> (+0.10%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabianvf fabianvf changed the title Revert ":bug: Fix session expiry when refresh tokens are disabled" 🌱 Revert "🐛 Fix session expiry when refresh tokens are disabled" Dec 13, 2023
)"

This reverts commit eea7835.

Signed-off-by: Fabian von Feilitzsch <[email protected]>
Copy link

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign off and then immediately merge

@sjd78
Copy link
Member

sjd78 commented Dec 13, 2023

#1616 fixes this issue properly, no revert needed

@fabianvf
Copy link
Contributor Author

ack, thanks @sjd78

@fabianvf fabianvf closed this Dec 13, 2023
@sjd78 sjd78 deleted the revert-1614-fix-expiry branch February 14, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants