-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Address style issues on assessment summary / questionnaire view #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
changed the title
🐛 Address style issues on assessment summary / questionnaire view…
🐛 Address style issues on assessment summary / questionnaire view
Feb 27, 2024
…onveyor#1702) Resolves https://issues.redhat.com/browse/MTA-2004 <img width="1197" alt="Screenshot 2024-02-27 at 9 59 25 AM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/720d137a-098b-4736-ba1c-b0905073c144"> --------- Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Ian Bolton <[email protected]>
this looks good |
ibolton336
added
the
cherry-pick/release-0.3
This PR should be cherry-picked to release-0.3 branch.
label
Feb 27, 2024
sjd78
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
) Resolves https://issues.redhat.com/browse/MTA-1880 - Adds spacing for vertical tabs to align with question table - Adds spacing for expanded section to meet PF standards as outlined in above issue comments from UXD - Adds Explanation term for explanation previously not labeled. <img width="1638" alt="Screenshot 2024-02-27 at 2 48 46 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/a5d915d9-7977-48cd-ac4c-5c3ca1cdc909"> --------- Signed-off-by: Ian Bolton <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
ibolton336
added a commit
that referenced
this pull request
Feb 28, 2024
) (#1719) Resolves https://issues.redhat.com/browse/MTA-1880 - Adds spacing for vertical tabs to align with question table - Adds spacing for expanded section to meet PF standards as outlined in above issue comments from UXD - Adds Explanation term for explanation previously not labeled. <img width="1638" alt="Screenshot 2024-02-27 at 2 48 46 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/a5d915d9-7977-48cd-ac4c-5c3ca1cdc909"> --------- Signed-off-by: Ian Bolton <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Ian Bolton <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-1880