Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Address style issues on assessment summary / questionnaire view #1706

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

ibolton336
Copy link
Member

Resolves https://issues.redhat.com/browse/MTA-1880

  • Adds spacing for vertical tabs to align with question table
  • Adds spacing for expanded section to meet PF standards as outlined in above issue comments from UXD
  • Adds Explanation term for explanation previously not labeled.
Screenshot 2024-02-27 at 2 48 46 PM

@ibolton336 ibolton336 changed the title 🐛 Address style issues on assessment summary / questionnaire view… 🐛 Address style issues on assessment summary / questionnaire view Feb 27, 2024
@JustinXHale
Copy link
Member

this looks good

@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Feb 27, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibolton336 ibolton336 merged commit 5a30824 into konveyor:main Feb 28, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
)

Resolves https://issues.redhat.com/browse/MTA-1880
- Adds spacing for vertical tabs to align with question table
- Adds spacing for expanded section to meet PF standards as outlined in
above issue comments from UXD
- Adds Explanation term for explanation previously not labeled.
<img width="1638" alt="Screenshot 2024-02-27 at 2 48 46 PM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/a5d915d9-7977-48cd-ac4c-5c3ca1cdc909">

---------

Signed-off-by: Ian Bolton <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
ibolton336 added a commit that referenced this pull request Feb 28, 2024
) (#1719)

Resolves https://issues.redhat.com/browse/MTA-1880
- Adds spacing for vertical tabs to align with question table
- Adds spacing for expanded section to meet PF standards as outlined in
above issue comments from UXD
- Adds Explanation term for explanation previously not labeled.
<img width="1638" alt="Screenshot 2024-02-27 at 2 48 46 PM"

src="https://github.com/konveyor/tackle2-ui/assets/11218376/a5d915d9-7977-48cd-ac4c-5c3ca1cdc909">

---------

Signed-off-by: Ian Bolton <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants