Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Capitalize first letter of tag source #1815

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Apr 3, 2024

@rszwajko
Copy link
Collaborator Author

rszwajko commented Apr 3, 2024

Depends on: #1802

@rszwajko
Copy link
Collaborator Author

rszwajko commented Apr 3, 2024

Before

Screenshot from 2024-04-02 15-14-08

After

Screenshot from 2024-04-02 15-10-41

@rszwajko rszwajko changed the title Capitalize first letter of tag source 🐛 Capitalize first letter of tag source Apr 3, 2024
@sjd78 sjd78 added this to the v0.3.1 milestone Apr 5, 2024
@sjd78 sjd78 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Apr 5, 2024
@sjd78 sjd78 removed this from the v0.3.1 milestone Apr 5, 2024
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko rszwajko marked this pull request as ready for review April 8, 2024 12:36
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78
Copy link
Member

sjd78 commented Apr 9, 2024

FWIW - the cherry-pick bot failed on 1802 (https://github.com/konveyor/tackle2-ui/actions/runs/8599628022/job/23562934915#step:4:31). That PR probably needs a manual backport before this PR is merged so the bot can create the cherry-pick automatically.

/ping @ibolton336 , @rszwajko

@sjd78 sjd78 added this to the v0.3.2 milestone Apr 9, 2024
@ibolton336
Copy link
Member

BP PR opened @sjd78 #1833

@ibolton336 ibolton336 merged commit ea23163 into konveyor:main Apr 9, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
ibolton336 pushed a commit that referenced this pull request Apr 10, 2024
Resolves: https://issues.redhat.com/browse/MTA-2287

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Radoslaw Szwajkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants