🐛 Fix deps filter crash bug by limiting tag grouping calculation to tag filters

[ibolton336]

Addresses issue #1944 introduced by #1903

Currently the operation to build the tag category labels is very expensive & is causing maximum update depth exceeded errors when performing a filter operation in some cases.

This PR introduces a quick fix to limit the label creation operation by categoryKey === 'tags'. We should circle back on this & see if there is a better way to implement the category / name grouping.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 42.06%. Comparing base (b654645) to head (47a076e).
Report is 150 commits behind head on main.

Files	Patch %	Lines
...ponents/FilterToolbar/MultiselectFilterControl.tsx	0.00%	23 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
+ Coverage   39.20%   42.06%   +2.85%     
==========================================
  Files         146      163      +17     
  Lines        4857     5240     +383     
  Branches     1164     1311     +147     
==========================================
+ Hits         1904     2204     +300     
- Misses       2939     3020      +81     
- Partials       14       16       +2     

Flag	Coverage Δ
client	42.06% <0.00%> (+2.85%)	⬆️
server	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rszwajko]

@ibolton336 @sjd78
The root cause seem to be chip group name collision. Both "Language" filter and "Tags" filter create chip group with title "Language". After renaming one of them the problem is solved (see below).
However tag categories, in general, are editable. We might run into more conflicts. The solution might be using a prefix for chip groups created from tags categories i.e. Tags/Language. What do you think?

diff --git a/client/src/app/pages/dependencies/dependencies.tsx b/client/src/app/pages/dependencies/dependencies.tsx
index 97db65ce..166ff7aa 100644
--- a/client/src/app/pages/dependencies/dependencies.tsx
+++ b/client/src/app/pages/dependencies/dependencies.tsx
@@ -75,7 +75,7 @@ export const Dependencies: React.FC = () => {
       },
       {
         categoryKey: "provider",
-        title: t("terms.language"),
+        title: "LL",
         type: FilterType.search,
         filterGroup: "Dependency",
         placeholderText:

[rszwajko]

@ibolton336 @sjd78
Further research revealed that the problem is in duplicated keys - ToolbarFilter derrives them from categoryName which in our filters usually comes from category.title.
I've created a draft PR with the fix ( #1949 ).