✨ Task table #1957
✨ Task table #1957
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
+ Coverage 39.20% 42.23% +3.03%
==========================================
Files 146 170 +24
Lines 4857 5448 +591
Branches 1164 1361 +197
==========================================
+ Hits 1904 2301 +397
- Misses 2939 3131 +192
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cancel and toggle preemption actions (for a Pending task)
Cancel action (for a Running task)
Optional columns: pod, started, terminated
|
Update the `Task` interface, and related, to follow the current definitions of Task REST resource[1] on the hub. Supports: konveyor#1955, konveyor#1956, konveyor#1957 [1] - https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748 Signed-off-by: Scott J Dickerson <[email protected]>
Update the `Task` interface, and related, to follow the current definitions of Task REST resource[1] on the hub. Supports: konveyor#1955, konveyor#1956, konveyor#1957 [1] - https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748 Signed-off-by: Scott J Dickerson <[email protected]>
Update the `Task` interface, and related, to follow the current definitions of Task REST resource[^1] on the hub. Supports: #1955, #1956, #1957 [^1]: https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748 --------- Signed-off-by: Scott J Dickerson <[email protected]>
rszwajko
force-pushed
the
taskTable
branch
2 times, most recently
from
70a7c80
to
98ffb60
Compare
|
@JustinXHale @rromannissen @jortel |
I think we're at the maximum number of columns we should be using, its borderline cramped. I think you've added relevant information. We could potentially save a little space using and provide some extra clarity using Relative Time or Timestamp |
Yep. The default columns take all space on a 1920x1080 screen. To show optional columns I had to hide some other columns.
Relative time makes harder to compare |
|
I agree with @JustinXHale 's remarks. Overall LGTM! |
|
This looks great! |
Resolves: #1938 Add a queued tasks count badge and a task list drawer. - Add a `TaskManagerContext` to control the count indicator and visibility of the drawer. This is a top level context so the task manager is available on all pages. The context itself monitors the task queue report endpoint[^1] that drives the notification badge count. - Use the standard `NotificationDrawer` attached to the `Page` layout to render the task manager item drawer. - The `TaskNotificationBadge` is integrated to the application's `HeaderApp`. - The `TaskManagerDrawer` shows the list of currently "queued" tasks[^2] in task id descending sort order (most recently created tasks on the top). - Each task item is rendered in a "collapsed" state and after a click will render "expanded". The expanded state include the started timestamp. - **_Note 1:_** Until fetch more / infinite scroll is implemented in the task manager drawer list, only the first 20 queued tasks will be displayed. - **_Note 2:_** Task actions need to be added to the task items. These should reuse the same set of actions as the task table in #1957. Related changes: - Update the `HeaderApp` to handle visibility of masthead toolbar items at the `ToolbarGroup` level. - Rename `SSOMenu` to `SsoToolbarItem`. - Updated the typing on a few task related API functions. [^1]: konveyor/tackle2-hub#641 [^2]: konveyor/tackle2-hub#640 --------- Signed-off-by: Scott J Dickerson <[email protected]>
Functional changes: 1. create task manager entry in the sidebar navigation list 2. place task page under /tasks route 3. present tasks in a server-filtered table 4. row actions supported: canceling, enable/disable preemption flag 5. use column management to hide optional columns: pod, started, terminated Related features: 1. make id property required in Task type 2. switch task update endpoint to use patch method 3. provide icon-to-state mapping that preserves original state names which are required for server filetring Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Functional changes:
terminated
Related features:
which are required for server filtering
Resolves: #1931