Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add mvn:// prefix to application binary value in post request #1968

Merged
merged 3 commits into from
Jun 20, 2024
Merged

✨ Add mvn:// prefix to application binary value in post request #1968

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c35b634
:sparkles: Add mvn:// prefix to application binary value in post request
ibolton336 Jun 19, 2024
a48bc7c
initial value parsing
ibolton336 Jun 19, 2024
e0543d8
Merge branch 'main' into binary-updates
ibolton336 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions client/src/app/pages/applications/components/application-form/application-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ export const useApplicationFormHook = ({
application: Application | null,
fieldName: string
) => {
const fieldList = application?.binary?.split(":") || [];
const binaryString = application?.binary?.startsWith("mvn://")
? application.binary.substring(6)
: application?.binary;

const fieldList = binaryString?.split(":") || [];

switch (fieldName) {
case "group":
return fieldList[0] || "";
Expand Down Expand Up @@ -258,6 +263,13 @@ export const useApplicationFormHook = ({
});

const onValidSubmit = (formValues: FormValues) => {
let binaryValue = formValues.packaging
? `${formValues.group}:${formValues.artifact}:${formValues.version}:${formValues.packaging}`
: `${formValues.group}:${formValues.artifact}:${formValues.version}`;
if (!binaryValue.startsWith("mvn://")) {
binaryValue = `mvn://${binaryValue}`;
}

const payload: New<Application> = {
name: formValues.name.trim(),
description: formValues.description.trim(),
Expand All @@ -282,10 +294,7 @@ export const useApplicationFormHook = ({
path: formValues.rootPath.trim(),
}
: undefined,

binary: formValues.packaging
? `${formValues.group}:${formValues.artifact}:${formValues.version}:${formValues.packaging}`
: `${formValues.group}:${formValues.artifact}:${formValues.version}`,
binary: binaryValue,

// Values not editable on the form but still need to be passed through
identities: application?.identities ?? undefined,
Expand Down
Loading