Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix application table isTaskCancellable #2023

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Jul 23, 2024

Application analysis tasks should be cancellable when the task in NOT in a terminal state. Use the
TaskStates.Terminal collection for the check so all current terminal states are considered.

Resolves: #1993
Resolves: https://issues.redhat.com/browse/MTA-3219

@sjd78 sjd78 added this to the v0.5.0 milestone Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.07%. Comparing base (b654645) to head (88296b0).
Report is 197 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
+ Coverage   39.20%   42.07%   +2.87%     
==========================================
  Files         146      171      +25     
  Lines        4857     5511     +654     
  Branches     1164     1313     +149     
==========================================
+ Hits         1904     2319     +415     
- Misses       2939     3176     +237     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.07% <ø> (+2.87%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Application analysis tasks should be cancellable when
the task in NOT in a terminal state.  Use the
`TaskStates.Terminal` collection for the check so all
current terminal states are considered.

Resolves: konveyor#1993
Resolves: https://issues.redhat.com/browse/MTA-3219

Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cancel task option enabled after cancel has completed
2 participants