🐛 Add application risk filter of "Unassessed" #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
+ Coverage 39.20% 42.33% +3.13%
==========================================
Files 146 172 +26
Lines 4857 5525 +668
Branches 1164 1381 +217
==========================================
+ Hits 1904 2339 +435
- Misses 2939 3071 +132
- Partials 14 115 +101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
reviewed
Jul 30, 2024
client/src/app/pages/applications/applications-table/applications-table.tsx
Outdated
Show resolved
Hide resolved
Resolves: https://issues.redhat.com/browse/MTA-2816 Application risk options are one of: - High (red) - Medium (yellow) - Low (green) - Unknown (unknown) - Unassessed (unassessed) Added the __Unassessed__ option to the risk filter list on the application table to have a complete set of risk filters. Note: To help test risk levels, the questionnaire `hack/import-questionnaire/assign-risk.yaml` has been added. The single question has a 1 to 1 mapping between answer and risk level. As long as that questionnaire is the only one active on the system, it works well to quickly assign risks to applications. Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
- Add "unassessed" as an office `Risk` type option
- Updated `RiskLabel` to handle undefined and arbitrary
strings as risk inputs. Consumers of the component
don't need to worry about the prop quite as much anymore.
- Where a string risk was getting looked at, force to
lower case first so all the constants match up.
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
rszwajko
approved these changes
Aug 1, 2024
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Aug 1, 2024
Resolves: https://issues.redhat.com/browse/MTA-2816 Application risk options are one of: - High (red) - Medium (yellow) - Low (green) - Unknown (unknown) - Unassessed (unassessed) Added the __Unassessed__ option to the risk filter list on the application table to have a complete set of risk filters. Note: To help test risk levels, the questionnaire `hack/import-questionnaire/assign-risk.yaml` has been added. The single question has a 1 to 1 mapping between answer and risk level. As long as that questionnaire is the only one active on the system, it works well to quickly assign risks to applications. --------- Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
that referenced
this pull request
Aug 1, 2024
…2032) (#2035) Backport-of: #2032 Resolves: https://issues.redhat.com/browse/MTA-2816 Application risk options are one of: - High (red) - Medium (yellow) - Low (green) - Unknown (unknown) - Unassessed (unassessed) Added the __Unassessed__ option to the risk filter list on the application table to have a complete set of risk filters. Note: To help test risk levels, the questionnaire `hack/import-questionnaire/assign-risk.yaml` has been added. The single question has a 1 to 1 mapping between answer and risk level. As long as that questionnaire is the only one active on the system, it works well to quickly assign risks to applications. Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-2816
Application risk options are one of:
Added the Unassessed option to the risk filter list on the application table to have a complete
set of risk filters.
Note: To help test risk levels, the questionnaire
hack/import-questionnaire/assign-risk.yamlhas been added. The single question has a 1 to 1 mapping between answer and risk level. As long as that questionnaire is the only one active on the system, it works well to quickly assign risks to applications.