Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Close dropdown after selection or click outside the list #2077

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Sep 4, 2024

Fix applies to bulk selection dropdown and to filter categories dropdown on all table-based screens.

Resolves: https://issues.redhat.com/browse/MTA-3321

@rszwajko rszwajko changed the title Close dropdown after selection or click outside the list 🐛 Close dropdown after selection or click outside the list Sep 4, 2024
@rszwajko rszwajko added this to the v0.5.2 milestone Sep 4, 2024
@rszwajko rszwajko added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch. label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.52%. Comparing base (b654645) to head (62b8b7f).
Report is 224 commits behind head on main.

Files with missing lines Patch % Lines
...src/app/components/FilterToolbar/FilterToolbar.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2077      +/-   ##
==========================================
+ Coverage   39.20%   42.52%   +3.32%     
==========================================
  Files         146      171      +25     
  Lines        4857     5505     +648     
  Branches     1164     1353     +189     
==========================================
+ Hits         1904     2341     +437     
- Misses       2939     3148     +209     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.52% <0.00%> (+3.32%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit 16f166f into konveyor:main Sep 4, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Fix applies to bulk selection dropdown and to filter categories dropdown
on all table-based screens.

Resolves:  https://issues.redhat.com/browse/MTA-3321

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
sjd78 pushed a commit that referenced this pull request Sep 4, 2024
…2078)

Fix applies to bulk selection dropdown and to filter categories dropdown
on all table-based screens.

Resolves:  https://issues.redhat.com/browse/MTA-3321
Backport-of: #2077

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants