Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add /kai reverse-proxy route. #2089

Merged
merged 1 commit into from
Sep 12, 2024
Merged

✨ Add /kai reverse-proxy route. #2089

merged 1 commit into from
Sep 12, 2024

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Sep 11, 2024

Signed-off-by: Jeff Ortel <[email protected]>
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.15%. Comparing base (b654645) to head (c81788d).
Report is 230 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
+ Coverage   39.20%   42.15%   +2.95%     
==========================================
  Files         146      174      +28     
  Lines        4857     5577     +720     
  Branches     1164     1376     +212     
==========================================
+ Hits         1904     2351     +447     
- Misses       2939     3210     +271     
- Partials       14       16       +2     
Flag Coverage Δ
client 42.15% <ø> (+2.95%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra proxy looks reasonable.

@sjd78 sjd78 merged commit bf587d3 into konveyor:main Sep 12, 2024
12 checks passed
sjd78 pushed a commit to sjd78/tackle2-ui that referenced this pull request Sep 12, 2024
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Sep 19, 2024
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants