Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix closing filter chips created via SelectFilterControl #2093

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Sep 13, 2024

Resolves: #2094

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 42.14%. Comparing base (b654645) to head (a45a5f2).
Report is 234 commits behind head on main.

Files with missing lines Patch % Lines
...p/components/FilterToolbar/SelectFilterControl.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
+ Coverage   39.20%   42.14%   +2.94%     
==========================================
  Files         146      174      +28     
  Lines        4857     5578     +721     
  Branches     1164     1398     +234     
==========================================
+ Hits         1904     2351     +447     
- Misses       2939     3106     +167     
- Partials       14      121     +107     
Flag Coverage Δ
client 42.14% <0.00%> (+2.94%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rszwajko rszwajko marked this pull request as ready for review September 13, 2024 16:52
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit 7768bf6 into konveyor:main Sep 13, 2024
12 checks passed
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
Shevijacobson pushed a commit to Shevijacobson/tackle2-ui that referenced this pull request Sep 18, 2024
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Sep 19, 2024
DvoraShechter1 pushed a commit to DvoraShechter1/tackle2-ui that referenced this pull request Oct 28, 2024
sarinailinger pushed a commit to sarinailinger/tackle2-ui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot close "Repository type" filter chips
2 participants