This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Added full cinder ID to candidateDeviceNodes #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems safe, because this is a candidate list, and these values are more complete than the 20 characters we've used before. Going to merge - but let me know if there's a reason to revert @olemarkus or @zetaab ! /approve |
|
Thanks again @goberle! Have you signed the kubernetes CLA? We're trying to merge this project into the kubernetes-sigs etcdadm project ( kubernetes-retired/etcdadm#180 (comment) ), and you can see we're hitting some CLA issues. I don't know if it's your account or someone else's though... Have you signed the CLA (or are you able to sign the CLA?) |
|
Hi @justinsb Thanks for the merge. I just signed the kubernetes CLA a minute ago, it should be ok now. Let me know if there is any more issues for merging upstream. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.