Use latest Mima and MMR extension #27
Conversation
There is NO NEED to build MavenProject, that in fact is not even part of Maven public API. Moreover, the reason why MavenProject is built is really just to grab "raw" and "effective" models, that is in fact model builder job to do. Clean up several other issues as well, drop the huge amount of not needed and/or unused dependencies as well.
|
Solves both, but of course you STILL need to add that "staging directory" or whatever as RemoteRepository. All the POMs (like parents etc, that are staged and inter-connected) must be resolvable by Resolver.... |
| * (parent, BOMs imported, etc) MUST BE RESOLVABLE. Hence, there is possibility to provide "extra" remote | ||
| * repositories. | ||
| */ | ||
| public static MavenProject createMavenProject(File pomFile, RemoteRepository... repositories) { |
There was a problem hiding this comment.
Does this code resolve POMs where certain properties are activated via profiles? The old code made sure to setup required activation points.
There was a problem hiding this comment.
Well, MIMA collects in same way the properties as Maven. OTOH, am really unsure what "os.detected.xxx" are, certainly are not set by Maven. Are you targeting here some specific plugin maybe?
There was a problem hiding this comment.
Right. That's why those oss.detected.xxx properties were in place, to make sure platform specific profiles were activated during resolution if needed. This means this PR is not behavior compatible.
+1, regardless of the solution adopted, it should somehow have a way to add the staging directory as a remote repository (via a system property perhaps?) |
|
Updated stuff with latest MIMA. Anyone any idea why gradle build fails with |
|
os-maven-plugin "simulation" left in, but am unsure why that one plugin needs special treatment, or in other words any other why not? This seems too "narrowly tailored" to something... but what? |
|
Also created separate mvnw PR, but this build seems to adjust enforcer to maven dependency (why?), so mvnw is here, but once other Pr is merged, irrelevant changes will be gone. |
|
Enforcer is to to validate the correct version of Maven is used regardless of if the wrapper is used or not. |
As pomchecker does way way too much for what it really needs. Building MavenProject just to get effective model is.... brrr, since Maven 3.1 there is ModelBuilder for that! Nevertheless, Mima MMR is made exactly for this use case (and is used in Toolbox as well).
Help needed: tame Gradle as it seems is not picking up new class from core?