Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test related Gradle deprecation warnings #936

Merged
merged 1 commit into from
Apr 13, 2024

Commits on Apr 12, 2024

  1. Fix test related Gradle deprecation warnings

    The following deprecation warnings have been fixed:
    
    > Task :common:jvmTest
    The automatic loading of test framework implementation dependencies has
    been deprecated. This is scheduled to be removed in Gradle 9.0. Declare
    the desired test framework directly on the test suite or explicitly
    declare the test framework implementation dependencies on the test's
    runtime classpath. Consult the upgrading guide for further information:
    https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#test_framework_implementation_dependencies
    
    -> fixed by adding an explicit runtimeOnly dependency on
       org.junit.platform:junit-platform-launcher
    
    > Task :core:live-tests:jvmTest
    No test executed. This behavior has been deprecated. This will fail with
    an error in Gradle 9.0. There are test sources present but no test was
    executed. Please check your test configuration. Consult the upgrading
    guide for further information:
    https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#test_task_fail_on_no_test_executed
    
    -> fixed by configuring Test tasks with useJUnitPlatform() in
       kord-internal-multiplatform-module (used by :core:live-tests)
    
    org.gradle.warning.mode was set to all to verify that these deprecation
    warnings are indeed fixed on CI.
    lukellmann committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d2ffde1 View commit details
    Browse the repository at this point in the history