Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sourceLink URL with non-deprecated URI constructor #938

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

SebastianAigner
Copy link
Contributor

Fixes failing Gradle import of the project since -Werror is set and the URL constructor is deprecated.

Fixes failing Gradle import of the project since -Werror is set and the URL constructor is deprecated.
Copy link
Member

@lukellmann lukellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, haven't run into this myself yet as I'm still using JDK 17 to run Gradle (this deprecation is since Java 20).

@lukellmann lukellmann merged commit 2518603 into kordlib:main Apr 18, 2024
5 of 6 checks passed
@DRSchlaubi
Copy link
Member

I think I fixed this in #855 too ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants