The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actionsx/prettier@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actionsx/prettier@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\lib.rs:394:17 | 394 | / tokio::select! { 395 | | _ = connection::connection_lifecycle_loop() => (), 396 | | _ = SHUTDOWN_NOTIFIER.notified() => (), 397 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\lib.rs:394:17 | 394 | / tokio::select! { 395 | | _ = connection::connection_lifecycle_loop() => (), 396 | | _ = SHUTDOWN_NOTIFIER.notified() => (), 397 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\lib.rs:241:13 | 241 | / tokio::select! { 242 | | _ = web_server => (), 243 | | _ = SHUTDOWN_NOTIFIER.notified() => (), 244 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\lib.rs:241:13 | 241 | / tokio::select! { 242 | | _ = web_server => (), 243 | | _ = SHUTDOWN_NOTIFIER.notified() => (), 244 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: very complex type used. Consider factoring parts into `type` definitions --> alvr\server\src\lib.rs:54:30 | 54 | static ref VIDEO_SENDER: Mutex<Option<mpsc::UnboundedSender<(VideoFrameHeaderPacket, Vec<u8>)>>> = | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\connection.rs:1107:9 | 1107 | / tokio::join!( 1108 | | async { 1109 | | alvr_common::show_err(connection_pipeline().await); ... | 1114 | | time::sleep(RETRY_CONNECT_MIN_INTERVAL), 1115 | | ); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::join` which comes from the expansion of the macro `tokio::join` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\connection.rs:1071:5 | 1071 | / tokio::select! { 1072 | | // Spawn new tasks and let the runtime manage threading 1073 | | res = spawn_cancelable(receive_loop) => { 1074 | | alvr_session::log_event(ServerEvent::ClientDisconnected); ... | 1101 | | } 1102 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\connection.rs:1071:5 | 1071 | / tokio::select! { 1072 | | // Spawn new tasks and let the runtime manage threading 1073 | | res = spawn_cancelable(receive_loop) => { 1074 | | alvr_session::log_event(ServerEvent::ClientDisconnected); ... | 1101 | | } 1102 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: length comparison to zero --> alvr\server\src\connection.rs:1019:59 | 1019 | if src_ham.vertices.len() == 0 || src_ham.indices.len() == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src_ham.indices.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

warning: length comparison to zero --> alvr\server\src\connection.rs:1019:28 | 1019 | if src_ham.vertices.len() == 0 || src_ham.indices.len() == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src_ham.vertices.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\connection.rs:594:25 | 594 | let stream_socket = tokio::select! { | _________________________^ 595 | | res = StreamSocketBuilder::connect_to_client( 596 | | client_ip, 597 | | settings.connection.stream_port, ... | 605 | | } 606 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\connection.rs:594:25 | 594 | let stream_socket = tokio::select! { | _________________________^ 595 | | res = StreamSocketBuilder::connect_to_client( 596 | | client_ip, 597 | | settings.connection.stream_port, ... | 605 | | } 606 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\connection.rs:542:9 | 542 | / tokio::select! { 543 | | res = try_connection_future => { 544 | | match res { 545 | | Either::Left(Ok(client_ip)) => { ... | 562 | | _ = CLIENTS_UPDATED_NOTIFIER.notified() => return Ok(()), 563 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\server\src\connection.rs:542:9 | 542 | / tokio::select! { 543 | | res = try_connection_future => { 544 | | match res { 545 | | Either::Left(Ok(client_ip)) => { ... | 562 | | _ = CLIENTS_UPDATED_NOTIFIER.notified() => return Ok(()), 563 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: `#[warn(clippy::incompatible_msrv)]` on by default = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field `version` is never read --> alvr\server\src\connection.rs:88:5 | 86 | struct ConnectionInfo { | -------------- field in this struct 87 | client_ip: IpAddr, 88 | version: Option<Version>, | ^^^^^^^

warning: field `hostname` is never read --> alvr\server\src\connection.rs:53:5 | 52 | struct ClientId { | -------- field in this struct 53 | hostname: String, | ^^^^^^^^ | = note: `ClientId` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: unused import: `prelude::*` --> alvr\server\src\lib.rs:19:37 | 19 | use alvr_common::{lazy_static, log, prelude::*, ALVR_VERSION}; | ^^^^^^^^^^

warning: unused imports: `Mat4` and `log` --> alvr\server\src\connection.rs:8:12 | 8 | glam::{Mat4, Quat, Vec2, Vec3}, | ^^^^ 9 | log, | ^^^ | = note: `#[warn(unused_imports)]` on by default

warning: the borrowed expression implements the required traits --> alvr\launcher\src\commands.rs:62:15 | 62 | .args(&["/PID", &pid.to_string(), "/F"]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/PID", &pid.to_string(), "/F"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\launcher\src\commands.rs:52:50 | 52 | spawn_no_window(Command::new("cmd").args(&["/C", "start", "steam://rungameid/250820"])); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "start", "steam://rungameid/250820"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: useless use of `vec!` --> alvr\xtask\src/main.rs:1165:36 | 1165 | let flavours = vec![ | ____________________________________^ 1166 | | (for_generic, AndroidFlavor::Generic, abi_target.clone()), 1167 | | (for_pico, AndroidFlavor::Pico, Option::None), 1168 | | ]; | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default help: you can use an array directly | 1165 ~ let flavours = [(for_generic, AndroidFlavor::Generic, abi_target.clone()), 1166 ~ (for_pico, AndroidFlavor::Pico, Option::None)]; |

warning: struct update has no effect, all the fields in the struct have already been specified --> alvr\xtask\src/main.rs:1098:27 | 1098 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update = note: `#[warn(clippy::needless_update)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:977:41 | 977 | .filter(|entry| is_package_file(&entry)) | ^^^^^^ help: change this to: `entry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: unneeded `return` statement --> alvr\xtask\src/main.rs:969:13 | 969 | return ["apk", "aar", "idsig"].contains(&ext_str); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 969 - return ["apk", "aar", "idsig"].contains(&ext_str); 969 + ["apk", "aar", "idsig"].contains(&ext_str) |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:850:61 | 850 | let run_ait_cmd = |cmd: &str| command::run_in(&ait_dir, &cmd).unwrap(); | ^^^^ help: change this to: `cmd` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: manual implementation of an assign operation --> alvr\xtask\src/main.rs:823:9 | 823 | archs = archs + "_debug"; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archs += "_debug"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `#[warn(clippy::assign_op_pattern)]` on by default

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:817:36 | 817 | alxr_client_build_dir.join(&cert), | ^^^^^ help: change this to: `cert` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:816:30 | 816 | alxr_client_dir.join(&cert), | ^^^^^ help: change this to: `cert` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: redundant closure --> alvr\xtask\src/main.rs:786:57 | 786 | for arch in [UWPArch::X86_64, UWPArch::Aarch64].map(|x| batch_arch_str(x)) { | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `batch_arch_str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:783:52 | 783 | let pack_map_path = alxr_client_build_dir.join(&pack_map_fname); | ^^^^^^^^^^^^^^^ help: change this to: `pack_map_fname` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:779:24 | 779 | .unwrap_or(&alxr_client_build_dir), | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `alxr_client_build_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:733:69 | 733 | let relative_path = linked_depend_file.strip_prefix(&linked_path).unwrap(); | ^^^^^^^^^^^^ help: change this to: `linked_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:731:56 | 731 | .filter(|entry| is_linked_depends_file(&entry)) | ^^^^^^ help: change this to: `entry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:683:36 | 683 | if afs::is_dynlib_file(&path) { | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: unneeded `return` statement --> alvr\xtask\src/main.rs:703:13 | 703 | return false; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 703 - return false; 703 + false |

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:612:40 | 612 | alxr_client_build_dir.join(&pdb_fname), | ^^^^^^^^^^ help: change this to: `pdb_fname` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:611:32 | 611 | artifacts_dir.join(&pdb_fname), | ^^^^^^^^^^ help: change this to: `pdb_fname` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:599:52 | 599 | .filter(|entry| is_linked_depends_file(&entry)) | ^^^^^^ help: change this to: `entry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:568:32 | 568 | if afs::is_dynlib_file(&path) { | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: unneeded `return` statement --> alvr\xtask\src/main.rs:588:9 | 588 | return false; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 588 - return false; 588 + false |

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:525:62 | 525 | if so_filename.to_string_lossy().starts_with(&key) { | ^^^^ help: change this to: `key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:522:52 | 522 | .filter(|path| afs::is_dynlib_file(&path)) | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src/main.rs:508:13 | 508 | &ffmpeg_build_dir, | ^^^^^^^^^^^^^^^^^ help: change this to: `ffmpeg_build_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: length comparison to zero --> alvr\xtask\src/main.rs:475:16 | 475 | if build_str.len() > 0 { | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!build_str.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

warning: length comparison to zero --> alvr\xtask\src/main.rs:474:12 | 474 | if features.len() > 0 { | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!features.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> alvr\xtask\src/main.rs:462:26 | 462 | fn to_str_vec(m: &Vec<(bool, &'static str)>) -> Vec<&'static str> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(bool, &'static str)]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> alvr\xtask\src/main.rs:407:21 | 407 | / match lp.as_str().strip_prefix("native=") { 408 | | Some(p) => { 409 | | linked_path_set.insert(p.into()); 410 | | } 411 | | None => (), 412 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 407 ~ if let Some(p) = lp.as_str().strip_prefix("native=") { 408 + linked_path_set.insert(p.into()); 409 + } |

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> alvr\xtask\src/main.rs:404:9 | 404 | / match message? { 405 | | Message::BuildScriptExecuted(script) => { 406 | | for lp in script.linked_paths.iter() { 407 | | match lp.as_str().strip_prefix("native=") { ... | 415 | | _ => (), 416 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 404 ~ if let Message::BuildScriptExecuted(script) = message? { 405 + for lp in script.linked_paths.iter() { 406 + match lp.as_str().strip_prefix("native=") { 407 + Some(p) => { 408 + linked_path_set.insert(p.into()); 409 + } 410 + None => (), 411 + } 412 + } 413 + } |

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:389:50 | 389 | let mut command = std::process::Command::new(&cmd); | ^^^^ help: change this to: `cmd` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: length comparison to zero --> alvr\xtask\src/main.rs:375:8 | 375 | if nightly_version.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!nightly_version.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:337:24 | 337 | fs::create_dir_all(&afs::build_dir().join(&artifact_name)).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::build_dir().join(&artifact_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:284:24 | 284 | fs::create_dir_all(&layout.dashboard_dir()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.dashboard_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:271:24 | 271 | fs::create_dir_all(&layout.resources_dir()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.resources_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:163:48 | 163 | fs::copy(lib.clone(), lib_dir.join(&lib_filename)).unwrap(); | ^^^^^^^^^^^^^ help: change this to: `lib_filename` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:136:24 | 136 | fs::create_dir_all(&layout.launcher_exe().parent().unwrap()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.launcher_exe().parent().unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:135:24 | 135 | fs::create_dir_all(&layout.openvr_driver_lib().parent().unwrap()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.openvr_driver_lib().parent().unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:134:24 | 134 | fs::create_dir_all(&afs::server_build_dir()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::server_build_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src/main.rs:133:24 | 133 | fs::remove_dir_all(&afs::server_build_dir()).ok(); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::server_build_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this function has too many arguments (8/7) --> alvr\xtask\src/main.rs:79:1 | 79 | / pub fn build_server( 80 | | is_release: bool, 81 | | experiments: bool, 82 | | fetch_crates: bool, ... | 87 | | reproducible: bool, 88 | | ) { | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: the borrowed expression implements the required traits --> alvr\xtask\src\version.rs:177:28 | 177 | .map(|d| base_dir.join(&d).to_str().unwrap().to_owned()) | ^^ help: change this to: `d` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: `filter` for `Ok` followed by `unwrap` --> alvr\xtask\src\dependencies.rs:204:18 | 204 | .filter(|result| result.is_ok()) | __________________^ 205 | | .map(|pp| pp.unwrap()) | |______________________________________^ help: consider using `flatten` instead: `flatten()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_filter_map = note: `#[warn(clippy::result_filter_map)]` on by default

warning: the borrowed expression implements the required traits --> alvr\xtask\src\dependencies.rs:196:15 | 196 | .args(&["-c", &cmdline]) | ^^^^^^^^^^^^^^^^^ help: change this to: `["-c", &cmdline]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: length comparison to zero --> alvr\xtask\src\dependencies.rs:124:8 | 124 | if install_prefix.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!install_prefix.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

warning: length comparison to zero --> alvr\xtask\src\dependencies.rs:52:22 | 52 | Some(ips) if ips.len() > 0 => { | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ips.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default

warning: the borrowed expression implements the required traits --> alvr\xtask\src\dependencies.rs:13:24 | 13 | fs::create_dir_all(&destination).unwrap(); | ^^^^^^^^^^^^ help: change this to: `destination` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src\dependencies.rs:12:24 | 12 | fs::remove_dir_all(&destination).ok(); | ^^^^^^^^^^^^ help: change this to: `destination` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: useless use of `format!` --> alvr\xtask\src\command.rs:154:31 | 154 | let result = Command::new(format!("cargo")) | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"cargo".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

warning: used consecutive `str::replace` call --> alvr\xtask\src\command.rs:149:10 | 149 | .replace('\r', "") | __________^ 150 | | .replace('\n', "") | |__________________________^ help: replace with: `replace(['\r', '\n'], "")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace = note: `#[warn(clippy::collapsible_str_replace)]` on by default

warning: the borrowed expression implements the required traits --> alvr\xtask\src\command.rs:141:19 | 141 | .args(&["-u", "+%Y.%m.%d"]) | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-u", "+%Y.%m.%d"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\xtask\src\command.rs:29:15 | 29 | .args(&[shell_flag, cmd]) | ^^^^^^^^^^^^^^^^^^ help: change this to: `[shell_flag, cmd]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: variable does not need to be mutable --> alvr\xtask\src/main.rs:1057:13 | 1057 | let mut ffmpeg_version: String = | ----^^^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1203:25 | 1203 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1199:25 | 1199 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1198:25 | 1198 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1189:25 | 1189 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1185:25 | 1185 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1184:25 | 1184 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1162:25 | 1162 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1158:25 | 1158 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1157:25 | 1157 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1151:25 | 1151 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1149:25 | 1149 | bundle_ffmpeg: bundle_ffmpeg, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_ffmpeg` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1148:25 | 1148 | no_nvidia: no_nvidia, | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_nvidia` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1147:25 | 1147 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1146:25 | 1146 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1134:25 | 1134 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1130:25 | 1130 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1129:25 | 1129 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1123:25 | 1123 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1119:25 | 1119 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1118:25 | 1118 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1110:25 | 1110 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1106:25 | 1106 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1105:25 | 1105 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1097:25 | 1097 | oculus_ext: oculus_ext, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oculus_ext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1096:25 | 1096 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1094:25 | 1094 | bundle_ffmpeg: bundle_ffmpeg, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_ffmpeg` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1093:25 | 1093 | no_nvidia: no_nvidia, | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_nvidia` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1092:25 | 1092 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> alvr\xtask\src/main.rs:1091:25 | 1091 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default

warning: deref which would be done by auto-deref --> alvr\audio\src\lib.rs:638:17 | 638 | &mut *self.sample_buffer.lock(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut self.sample_buffer.lock()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

warning: accessing first element with `from_openvr_paths(paths_json).get(0)` --> alvr\commands\src\openvrpaths.rs:66:17 | 66 | trace_none!(from_openvr_paths(paths_json).get(0).cloned()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_openvr_paths(paths_json).first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default

warning: unneeded late initialization --> alvr\commands\src\firewall.rs:20:5 | 20 | let exit_status; | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init = note: `#[warn(clippy::needless_late_init)]` on by default help: move the declaration `exit_status` here and remove the assignments from the branches | 20 ~ 21 | 22 ~ let exit_status = if cfg!(target_os = "linux") { 23 | let action = if add { "add" } else { "remove" }; 24 | // run as normal user since we use pkexec to sudo 25 ~ Command::new("bash") 26 | .arg("/usr/libexec/alvr/alvr_fw_config.sh") 27 | .arg(action) 28 | .status() 29 ~ .map_err(|_| -1)? 30 | } else { ... 61 | // run with admin privileges 62 ~ runas::Command::new(script_path) 63 | .gui(true) // UAC, if available 64 | .status() 65 ~ .map_err(|_| -1)? 66 ~ }; |

warning: unused import: `alvr_filesystem as afs` --> alvr\server\build.rs:1:5 | 1 | use alvr_filesystem as afs; | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\sockets\src\lib.rs:74:17 | 74 | / tokio::select! { 75 | | res = future => res, 76 | | _ = cancel_receiver => Ok(()), 77 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0` --> alvr\sockets\src\lib.rs:74:17 | 74 | / tokio::select! { 75 | | res = future => res, 76 | | _ = cancel_receiver => Ok(()), 77 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: `#[warn(clippy::incompatible_msrv)]` on by default = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field `stream_id` is never read --> alvr\sockets\src\stream_socket\mod.rs:220:5 | 219 | pub struct StreamReceiver<T> { | -------------- field in this struct 220 | stream_id: StreamId, | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused import: `collections::HashMap` --> alvr\sockets\src\packets.rs:1:11 | 1 | use std::{collections::HashMap, time::Duration}; | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: the borrowed expression implements the required traits --> alvr\session\src\lib.rs:617:53 | 617 | let session_desc = match fs::read_to_string(&session_path) { | ^^^^^^^^^^^^^ help: change this to: `session_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: unused import: `DictionaryDefault` --> alvr\session\src\settings.rs:4:23 | 4 | use settings_schema::{DictionaryDefault, EntryData, SettingsSchema, Switch, SwitchDefault}; | ^^^^^^^^^^^^^^^^^

warning: unused import: `alvr_common::ALVR_VERSION` --> alvr\session\src\settings.rs:1:5 | 1 | use alvr_common::ALVR_VERSION; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: useless use of `format!` --> alvr\filesystem\src\lib.rs:101:27 | 101 | let alxr_client_dir = format!("alxr_client_uwp"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"alxr_client_uwp".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

warning: unneeded `return` statement --> alvr\filesystem\src\lib.rs:29:5 | 29 | return false; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 29 - return false; 29 + false |

warning: useless use of `format!` --> alvr\filesystem\src\lib.rs:101:27 | 101 | let alxr_client_dir = format!("alxr_client_uwp"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"alxr_client_uwp".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

warning: unneeded `return` statement --> alvr\filesystem\src\lib.rs:29:5 | 29 | return false; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 29 - return false; 29 + false |

warning: the borrowed expression implements the required traits --> alvr\settings-schema-derive\src\lib.rs:406:40 | 406 | _ => error("Unsupported type", &ty), | ^^^ help: change this to: `ty` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> alvr\settings-schema-derive\src\lib.rs:403:78 | 403 | error("Generics are supported only for Option, Switch, Vec", &ty) | ^^^ help: change this to: `ty` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default