Update Cargo.lock #508
clippy
110 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 110 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.74.1 (a28077b28 2023-12-04)
- cargo 1.74.1 (ecb9851af 2023-10-18)
- clippy 0.1.74 (a28077b2 2023-12-04)
Annotations
Check warning on line 54 in alvr\server\src\lib.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr\server\src\lib.rs:54:30
|
54 | static ref VIDEO_SENDER: Mutex<Option<mpsc::UnboundedSender<(VideoFrameHeaderPacket, Vec<u8>)>>> =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 88 in alvr\server\src\connection.rs
github-actions / clippy
field `version` is never read
warning: field `version` is never read
--> alvr\server\src\connection.rs:88:5
|
86 | struct ConnectionInfo {
| -------------- field in this struct
87 | client_ip: IpAddr,
88 | version: Option<Version>,
| ^^^^^^^
Check warning on line 53 in alvr\server\src\connection.rs
github-actions / clippy
field `hostname` is never read
warning: field `hostname` is never read
--> alvr\server\src\connection.rs:53:5
|
52 | struct ClientId {
| -------- field in this struct
53 | hostname: String,
| ^^^^^^^^
|
= note: `ClientId` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check warning on line 19 in alvr\server\src\lib.rs
github-actions / clippy
unused import: `prelude::*`
warning: unused import: `prelude::*`
--> alvr\server\src\lib.rs:19:37
|
19 | use alvr_common::{lazy_static, log, prelude::*, ALVR_VERSION};
| ^^^^^^^^^^
Check warning on line 8 in alvr\server\src\connection.rs
github-actions / clippy
unused imports: `Mat4`, `log`
warning: unused imports: `Mat4`, `log`
--> alvr\server\src\connection.rs:8:12
|
8 | glam::{Mat4, Quat, Vec2, Vec3},
| ^^^^
9 | log,
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 638 in alvr\audio\src\lib.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> alvr\audio\src\lib.rs:638:17
|
638 | &mut *self.sample_buffer.lock(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut self.sample_buffer.lock()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
Check warning on line 1 in alvr\server\build.rs
github-actions / clippy
unused import: `alvr_filesystem as afs`
warning: unused import: `alvr_filesystem as afs`
--> alvr\server\build.rs:1:5
|
1 | use alvr_filesystem as afs;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 220 in alvr\sockets\src\stream_socket\mod.rs
github-actions / clippy
field `stream_id` is never read
warning: field `stream_id` is never read
--> alvr\sockets\src\stream_socket\mod.rs:220:5
|
219 | pub struct StreamReceiver<T> {
| -------------- field in this struct
220 | stream_id: StreamId,
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 617 in alvr\session\src\lib.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\session\src\lib.rs:617:53
|
617 | let session_desc = match fs::read_to_string(&session_path) {
| ^^^^^^^^^^^^^ help: change this to: `session_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 62 in alvr\launcher\src\commands.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\launcher\src\commands.rs:62:15
|
62 | .args(&["/PID", &pid.to_string(), "/F"])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/PID", &pid.to_string(), "/F"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 52 in alvr\launcher\src\commands.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\launcher\src\commands.rs:52:50
|
52 | spawn_no_window(Command::new("cmd").args(&["/C", "start", "steam://rungameid/250820"]));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "start", "steam://rungameid/250820"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 10 in alvr\launcher\src\commands.rs
github-actions / clippy
unused import: `Signal`
warning: unused import: `Signal`
--> alvr\launcher\src\commands.rs:10:68
|
10 | use sysinfo::{PidExt, ProcessExt, ProcessRefreshKind, RefreshKind, Signal, System, SystemExt};
| ^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 1162 in alvr\xtask\src\main.rs
github-actions / clippy
useless use of `vec!`
warning: useless use of `vec!`
--> alvr\xtask\src\main.rs:1156:36
|
1156 | let flavours = vec![
| ____________________________________^
1157 | | (for_generic, AndroidFlavor::Generic),
1158 | | (for_oculus_quest, AndroidFlavor::OculusQuest),
1159 | | (for_pico, AndroidFlavor::Pico),
1160 | | (for_pico_neo_v4, AndroidFlavor::PicoV4),
1161 | | (for_lynx, AndroidFlavor::Lynx),
1162 | | ];
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
1156 ~ let flavours = [(for_generic, AndroidFlavor::Generic),
1157 + (for_oculus_quest, AndroidFlavor::OculusQuest),
1158 + (for_pico, AndroidFlavor::Pico),
1159 + (for_pico_neo_v4, AndroidFlavor::PicoV4),
1160 ~ (for_lynx, AndroidFlavor::Lynx)];
|
Check warning on line 1089 in alvr\xtask\src\main.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> alvr\xtask\src\main.rs:1089:27
|
1089 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
Check warning on line 967 in alvr\xtask\src\main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:967:41
|
967 | .filter(|entry| is_package_file(&entry))
| ^^^^^^ help: change this to: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 959 in alvr\xtask\src\main.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> alvr\xtask\src\main.rs:959:13
|
959 | return ["apk", "aar", "idsig"].contains(&ext_str);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
959 - return ["apk", "aar", "idsig"].contains(&ext_str);
959 + ["apk", "aar", "idsig"].contains(&ext_str)
|
Check warning on line 839 in alvr\xtask\src\main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:839:61
|
839 | let run_ait_cmd = |cmd: &str| command::run_in(&ait_dir, &cmd).unwrap();
| ^^^^ help: change this to: `cmd`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 812 in alvr\xtask\src\main.rs
github-actions / clippy
manual implementation of an assign operation
warning: manual implementation of an assign operation
--> alvr\xtask\src\main.rs:812:9
|
812 | archs = archs + "_debug";
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archs += "_debug"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
Check warning on line 806 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:806:36
|
806 | alxr_client_build_dir.join(&cert),
| ^^^^^ help: change this to: `cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 805 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:805:30
|
805 | alxr_client_dir.join(&cert),
| ^^^^^ help: change this to: `cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 775 in alvr\xtask\src\main.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> alvr\xtask\src\main.rs:775:57
|
775 | for arch in [UWPArch::X86_64, UWPArch::Aarch64].map(|x| batch_arch_str(x)) {
| ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `batch_arch_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Check warning on line 772 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:772:52
|
772 | let pack_map_path = alxr_client_build_dir.join(&pack_map_fname);
| ^^^^^^^^^^^^^^^ help: change this to: `pack_map_fname`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 768 in alvr\xtask\src\main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:768:24
|
768 | .unwrap_or(&alxr_client_build_dir),
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `alxr_client_build_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 749 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:749:32
|
749 | fs::copy(&src_packed_file, &dst_packed_file).unwrap();
| ^^^^^^^^^^^^^^^^ help: change this to: `dst_packed_file`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 722 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:722:69
|
722 | let relative_path = linked_depend_file.strip_prefix(&linked_path).unwrap();
| ^^^^^^^^^^^^ help: change this to: `linked_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args