perf report: Add a tip about source line numbers with overhead #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a existing tip as below.
If you have debuginfo enabled, try: perf report -s sym,srcline
However this tip only describe a condition to use --sort sym,scrline options.
So there is lack of explanation in the tip. I think that it would be better to
add a tip that exactly explain the feature of --sort srcline.
Signed-off-by: Seonyoung Kim <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Taeung Song <[email protected]>
|
The description is only for developers. I can't understand completely. Therefore, perf report -s sym, srcline are required more specific description for users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a existing tip as below.
However this tip only describe a condition to use --sort sym,scrline options.
So there is lack of explanation in the tip. I think that it would be better to
add a tip that exactly explain the feature of --sort srcline.
Signed-off-by: Seonyoung Kim [email protected]
Cc: Namhyung Kim [email protected]
Cc: Jiri Olsa [email protected]
Cc: Taeung Song [email protected]