Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evals and other minor changes #66

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Fix evals and other minor changes #66

merged 5 commits into from
Jun 3, 2022

Conversation

solivella
Copy link
Collaborator

  1. Replace non-standard evals with direct internal function calls
  2. Replace arg and arg type in get_census_data (counties --> county.list) to list of county names, allowing state-specific county name vectors
  3. Unexport internal funs; only export three main functions
  4. Eliminate unnecessary dependency on stringr and devtools
  5. Don't ask for census related things if surname.only==TRUE
  6. Change use_counties to use.counties to match style of other args

@solivella solivella requested a review from 1beb June 3, 2022 06:31
@1beb 1beb merged commit 8a6cd2b into hwru Jun 3, 2022
@solivella solivella deleted the fix-evals branch June 3, 2022 06:42
@1beb
Copy link
Collaborator

1beb commented Jun 3, 2022

@solivella A small update should be added. You've wrapped the note about race init in control$verbose, however, what if no one defines control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants