add support for GHC 9.4.x #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(just noticed #123 as well, but this is a slightly different approach) |
parsonsmatt
reviewed
Nov 21, 2022
Comment on lines
+62
to
+66
| #if __GLASGOW_HASKELL__ >= 904 | ||
| import GHC.Prim (eqWord64#, ltWord64#) | ||
| #define eqWord eqWord64 | ||
| #define ltWord ltWord64 | ||
| #else |
There was a problem hiding this comment.
lol this is much nicer than my PR, well done!
Closed
int-index
approved these changes
Nov 22, 2022
|
I think this PR is obsolete now, right? |
|
yup, GHC-9.4 support was added in #126, so I'll close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several redundant import warnings, but I'm not certain of the best way to handle those in a backwards compatible way. :)