Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problems, if a name starts with a underscore #120

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fixed problems, if a name starts with a underscore #120

merged 1 commit into from
Apr 22, 2020

Conversation

julian-r
Copy link
Contributor

Names with underscore did not work, so here a small patch with a test

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #120   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          824       828    +4     
  Branches       169       170    +1     
=========================================
+ Hits           824       828    +4     
Impacted Files Coverage Δ
datamodel_code_generator/parser/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6055368...24e02ff. Read the comment docs.

@koxudaxi koxudaxi merged commit 7604341 into koxudaxi:master Apr 22, 2020
@koxudaxi
Copy link
Owner

@julian-r

Thank you for creating this PR.
Looks good!!

I have merged and released a new version as 0.4.9.

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants